[Store] Add Redis #269

lyrixx · 2025-08-06T12:42:04Z

Q	A
Bug fix?	no
New feature?	yes
Docs?	no
Issues
License	MIT

I continue to bench different stores, and the next one is Redis

Demo

$ php rag/redis.php                                                                                                                   
Here are some movies that fit the theme of technology:                                                                                                                                      
                                                                                                                                                                                            
1. **The Matrix**                                                                                                                                                                           
   - **Description**: A hacker discovers the world he lives in is a simulated reality and joins a rebellion to overthrow its controllers.                                                   
   - **Director**: The Wachowskis                                                                                                                                                           
                                                                                                                                                                                            
2. **Interstellar**                                                                                                                                                                         
   - **Description**: A team of explorers travel through a wormhole in space in an attempt to ensure humanity's survival.                                                                   
   - **Director**: Christopher Nolan                                                                                                                                                        
                                                                                                                                                                                            
3. **Jurassic Park**                                                                                                                                                                        
   - **Description**: During a preview tour, a theme park suffers a major power breakdown that allows its cloned dinosaur exhibits to run amok.                                             
   - **Director**: Steven Spielberg

Symfony configuration

With a custom redis connection

ai:
    store:
        redis:
            name:
                # a service id of a Redis client
                client: my_redis
                index_name: "my_index" # required
                key_prefix: 'vector:'

                # Distance metric to use for vector similarity search
                distance: !php/enum Symfony\AI\Store\Bridge\Redis\Distance::Cosine

services:
    my_redis:
        class: Redis
        arguments:
            $options:
                host: '127.0.0.1'

Without a custom redis connection

ai:
    store:
        redis:
            name:
                # see https://github.com/phpredis/phpredis?tab=readme-ov-file#example-1
                connection_parameters:
                    host: 127.0.0.1
                    port: 6379

                index_name: "my_index"

src/ai-bundle/config/options.php

chr-hertel · 2025-08-07T20:25:39Z

Could you bring in a rag example as well, please? redis cloud or docker compose maybe

OskarStark · 2025-08-07T21:02:02Z

docker compose if possible please 🙏

lyrixx · 2025-08-12T13:47:37Z

I added a rag example, with docker compose. I also updated the PR description

src/ai-bundle/src/AiBundle.php

src/store/src/Bridge/Redis/Store.php

chr-hertel

The example is now easy to use & work - thanks for that!
The bundle config looks fishy tho ...

chr-hertel · 2025-08-14T22:32:12Z

Needs a rebase after #317

OskarStark · 2025-08-30T11:23:42Z

Open to finish this PR?

lyrixx · 2025-09-01T12:48:20Z

Oupsy, I forgot this one. I'll finish it ASAP

lyrixx · 2025-09-18T12:22:11Z

Here we go!

I have rebased the PR, fixed conflict, and adapted code to new interfaces
Fixed the bundle configuration, add more validation
Fixed tests and examples
Updated the PR description to configure how to use with the framework bundle

src/store/src/Bridge/Redis/Distance.php

src/store/src/Bridge/Redis/Store.php

OskarStark

Some minors, afterwards good to merge

src/store/src/Bridge/Redis/Store.php

Copilot

Pull Request Overview

This PR adds Redis vector store support to the Symfony AI Store component, enabling developers to use Redis as a backend for vector storage and similarity search operations.

Key changes:

Implementation of Redis vector store with RedisSearch and JSON support
Configuration options for Redis connections (direct client or connection parameters)
Support for different distance metrics (Cosine, L2, IP) and indexing methods

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
src/store/src/Bridge/Redis/Store.php	Core Redis store implementation with vector operations and search functionality
src/store/src/Bridge/Redis/Distance.php	Enum for Redis distance metrics (Cosine, L2, IP)
src/store/tests/Bridge/Redis/StoreTest.php	Comprehensive test suite covering all Redis store operations
src/ai-bundle/src/AiBundle.php	Bundle integration for Redis store configuration
src/ai-bundle/config/options.php	Configuration schema for Redis store options
examples/rag/redis.php	Example implementation demonstrating Redis store usage
examples/compose.yaml	Docker Compose service for Redis development
src/store/composer.json	Added polyfill dependency for PHP 8.3 features
src/store/CHANGELOG.md	Documentation update listing Redis as supported store
src/ai-bundle/tests/DependencyInjection/AiBundleTest.php	Test configuration for Redis store

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

src/ai-bundle/src/AiBundle.php

OskarStark · 2025-09-19T14:15:55Z

src/ai-bundle/src/AiBundle.php

 use Symfony\AI\Platform\Bridge\VertexAi\PlatformFactory as VertexAiPlatformFactory;
 use Symfony\AI\Platform\Bridge\Voyage\PlatformFactory as VoyagePlatformFactory;
 use Symfony\AI\Platform\Exception\RuntimeException;
-use Symfony\AI\Platform\Model;


Why this removal?

It's not used, isn't?

src/ai-bundle/src/AiBundle.php

OskarStark · 2025-10-02T12:15:10Z

Lets finish this one @lyrixx 🚀 👏

src/store/src/Bridge/ClickHouse/Store.php

src/store/src/Bridge/Redis/Store.php

lyrixx · 2025-10-03T14:41:21Z

Here we go 🚀 !

I hope and think I addressed all comments.
Tests are all green 🎉

Thanks for the review, and sorry for the slow tempo on this one!

OskarStark · 2025-10-03T16:36:28Z

Thank you, works great:

OskarStark · 2025-10-03T16:37:35Z

It took time, but here we go, this is in now. Thank you very much @lyrixx.

lyrixx requested review from chr-hertel, Nyholm and OskarStark as code owners August 6, 2025 12:42

carsonbot added Feature New feature Store Issues & PRs about the AI Store component Status: Needs Review labels Aug 6, 2025

lyrixx force-pushed the store-redis branch from e8a3fc0 to c54e2e0 Compare August 6, 2025 13:16

OskarStark reviewed Aug 6, 2025

View reviewed changes

src/ai-bundle/config/options.php Show resolved Hide resolved

chr-hertel added Status: Needs Work and removed Status: Needs Review labels Aug 11, 2025

lyrixx force-pushed the store-redis branch from c54e2e0 to 87dfa66 Compare August 12, 2025 13:41

carsonbot added Status: Needs Review and removed Status: Needs Work labels Aug 12, 2025

lyrixx force-pushed the store-redis branch from 87dfa66 to 9911d50 Compare August 12, 2025 13:45

chr-hertel reviewed Aug 14, 2025

View reviewed changes

src/ai-bundle/src/AiBundle.php Outdated Show resolved Hide resolved

chr-hertel reviewed Aug 14, 2025

View reviewed changes

src/store/src/Bridge/Redis/Store.php Outdated Show resolved Hide resolved

chr-hertel requested changes Aug 14, 2025

View reviewed changes

carsonbot added Status: Needs Work and removed Status: Needs Review labels Aug 14, 2025

lyrixx force-pushed the store-redis branch from 9911d50 to b1bc4d6 Compare September 18, 2025 12:20

carsonbot added Status: Needs Review and removed Status: Needs Work labels Sep 18, 2025

lyrixx force-pushed the store-redis branch from b1bc4d6 to e8d1b3c Compare September 18, 2025 12:23

OskarStark reviewed Sep 19, 2025

View reviewed changes

src/store/src/Bridge/Redis/Distance.php Outdated Show resolved Hide resolved

OskarStark reviewed Sep 19, 2025

View reviewed changes

src/store/src/Bridge/Redis/Store.php Outdated Show resolved Hide resolved

OskarStark reviewed Sep 19, 2025

View reviewed changes

src/store/src/Bridge/Redis/Store.php Outdated Show resolved Hide resolved

OskarStark reviewed Sep 19, 2025

View reviewed changes

src/store/src/Bridge/Redis/Store.php Show resolved Hide resolved

OskarStark approved these changes Sep 19, 2025

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels Sep 19, 2025

OskarStark reviewed Sep 19, 2025

View reviewed changes

src/store/src/Bridge/Redis/Store.php Show resolved Hide resolved

OskarStark reviewed Sep 19, 2025

View reviewed changes

src/store/src/Bridge/Redis/Store.php Outdated Show resolved Hide resolved

OskarStark reviewed Sep 19, 2025

View reviewed changes

src/store/src/Bridge/Redis/Store.php Outdated Show resolved Hide resolved

OskarStark requested a review from Copilot September 19, 2025 14:13

carsonbot added Status: Needs Review and removed Status: Reviewed labels Sep 19, 2025

Copilot AI reviewed Sep 19, 2025

View reviewed changes

src/ai-bundle/src/AiBundle.php Show resolved Hide resolved

symfony deleted a comment from Copilot AI Sep 19, 2025

OskarStark reviewed Sep 19, 2025

View reviewed changes

OskarStark reviewed Oct 2, 2025

View reviewed changes

src/ai-bundle/src/AiBundle.php Outdated Show resolved Hide resolved

lyrixx force-pushed the store-redis branch from facd849 to 0647c21 Compare October 3, 2025 13:37

OskarStark reviewed Oct 3, 2025

View reviewed changes

src/store/src/Bridge/ClickHouse/Store.php Outdated Show resolved Hide resolved

src/store/src/Bridge/Redis/Store.php Show resolved Hide resolved

lyrixx force-pushed the store-redis branch 2 times, most recently from a950ab0 to 8d4e8e9 Compare October 3, 2025 13:56

[Store] Add support for Redis

c5aa431

lyrixx force-pushed the store-redis branch from 8d4e8e9 to c5aa431 Compare October 3, 2025 14:01

lyrixx requested a review from chr-hertel October 3, 2025 14:40

OskarStark merged commit 0fc7fab into symfony:main Oct 3, 2025
19 of 20 checks passed

lyrixx deleted the store-redis branch October 3, 2025 19:46

Uh oh!

[Store] Add Redis #269

[Store] Add Redis #269

Uh oh!

Conversation

lyrixx commented Aug 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Demo

Symfony configuration

With a custom redis connection

Without a custom redis connection

Uh oh!

Uh oh!

chr-hertel commented Aug 7, 2025

Uh oh!

OskarStark commented Aug 7, 2025

Uh oh!

lyrixx commented Aug 12, 2025

Uh oh!

Uh oh!

Uh oh!

chr-hertel left a comment

Choose a reason for hiding this comment

Uh oh!

chr-hertel commented Aug 14, 2025

Uh oh!

OskarStark commented Aug 30, 2025

Uh oh!

lyrixx commented Sep 1, 2025

Uh oh!

lyrixx commented Sep 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

OskarStark left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

OskarStark Sep 19, 2025

Choose a reason for hiding this comment

Uh oh!

lyrixx Oct 3, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OskarStark commented Oct 2, 2025

Uh oh!

Uh oh!

Uh oh!

lyrixx commented Oct 3, 2025

Uh oh!

OskarStark commented Oct 3, 2025

Uh oh!

OskarStark commented Oct 3, 2025

Uh oh!

Uh oh!

Uh oh!

lyrixx commented Aug 6, 2025 •

edited

Loading

lyrixx commented Sep 18, 2025 •

edited

Loading